Skip to content

Conversation

@arad-starkware
Copy link
Collaborator

@arad-starkware arad-starkware commented Nov 17, 2025

This change is Reviewable


Note

Convert repo from a workspace to a single Cairo package and adjust CI/script paths accordingly.

  • Build/Config:
    • Replace workspace setup with root Scarb.toml single-package config ([package], [dependencies]/[dev-dependencies], targets, profiles, tools, tests, features).
    • Remove workspace/apps/staking/contracts/Scarb.toml.
  • CI:
    • Update Codecov input to coverage/coverage.lcov in .github/workflows/on-pull-request.yaml.
  • Scripts:
    • Point scripts/check_all_flows_have_test.py CONTRACTS_FOLDER to repo root (was workspace/apps/staking/contracts).

Written by Cursor Bugbot for commit 18ae2df. This will update automatically on new commits. Configure here.

Copy link
Collaborator Author

arad-starkware commented Nov 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arad-starkware arad-starkware mentioned this pull request Nov 17, 2025
@arad-starkware arad-starkware self-assigned this Nov 17, 2025
@arad-starkware arad-starkware marked this pull request as ready for review November 17, 2025 12:47
@arad-starkware arad-starkware force-pushed the arad/chore_remove_workspace_change_to_single_package_repo branch from d2569df to 7a22829 Compare November 17, 2025 12:55
@arad-starkware arad-starkware force-pushed the arad/chore_remove_workspace_change_to_single_package_repo branch from 7a22829 to 8dc8afc Compare November 17, 2025 12:56
Base automatically changed from arad/ci_add_pr_ci to main November 17, 2025 13:08
@arad-starkware arad-starkware force-pushed the arad/chore_remove_workspace_change_to_single_package_repo branch from 8dc8afc to e497862 Compare November 17, 2025 13:10
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.53%. Comparing base (a28d60e) to head (18ae2df).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   95.43%   95.53%   +0.09%     
==========================================
  Files          45       45              
  Lines        9446     9657     +211     
==========================================
+ Hits         9015     9226     +211     
  Misses        431      431              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arad-starkware arad-starkware force-pushed the arad/chore_remove_workspace_change_to_single_package_repo branch 4 times, most recently from f3643b3 to bd03b48 Compare November 20, 2025 10:08
@arad-starkware arad-starkware force-pushed the arad/chore_remove_workspace_change_to_single_package_repo branch from bd03b48 to 18ae2df Compare November 20, 2025 11:22
Copy link
Collaborator

@NirLevi-starkware NirLevi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@NirLevi-starkware reviewed 63 of 70 files at r1, 2 of 2 files at r2, 4 of 6 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noa-starkware)

@arad-starkware arad-starkware added this pull request to the merge queue Nov 20, 2025
@arad-starkware arad-starkware merged commit 2f7be63 into main Nov 20, 2025
7 checks passed
Copy link
Collaborator Author

Merge activity

@arad-starkware arad-starkware deleted the arad/chore_remove_workspace_change_to_single_package_repo branch November 20, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants